Commit 244d4bfd authored by Taylor Otwell's avatar Taylor Otwell

Fix bugs in Redis class.

parent 13a70bcc
...@@ -113,7 +113,11 @@ return array( ...@@ -113,7 +113,11 @@ return array(
'redis' => array( 'redis' => array(
'default' => array('host' => '127.0.0.1', 'port' => 6379), 'default' => array(
'host' => '127.0.0.1',
'port' => 6379,
'database' => 0
),
), ),
......
...@@ -16,6 +16,13 @@ class Redis { ...@@ -16,6 +16,13 @@ class Redis {
*/ */
protected $port; protected $port;
/**
* The databse number the connection selects on load.
*
* @var int
*/
protected $database;
/** /**
* The connection to the Redis database. * The connection to the Redis database.
* *
...@@ -35,12 +42,14 @@ class Redis { ...@@ -35,12 +42,14 @@ class Redis {
* *
* @param string $host * @param string $host
* @param string $port * @param string $port
* @param int $database
* @return void * @return void
*/ */
public function __construct($host, $port) public function __construct($host, $port, $database = 0)
{ {
$this->host = $host; $this->host = $host;
$this->port = $port; $this->port = $port;
$this->database = $database;
} }
/** /**
...@@ -68,7 +77,9 @@ class Redis { ...@@ -68,7 +77,9 @@ class Redis {
throw new \Exception("Redis database [$name] is not defined."); throw new \Exception("Redis database [$name] is not defined.");
} }
static::$databases[$name] = new static($config['host'], $config['port']); extract($config);
static::$databases[$name] = new static($host, $port, $database);
} }
return static::$databases[$name]; return static::$databases[$name];
...@@ -95,6 +106,17 @@ class Redis { ...@@ -95,6 +106,17 @@ class Redis {
$response = trim(fgets($this->connection, 512)); $response = trim(fgets($this->connection, 512));
return $this->parse($response);
}
/**
* Parse and return the response from the Redis database.
*
* @param string $response
* @return mixed
*/
protected function parse($response)
{
switch (substr($response, 0, 1)) switch (substr($response, 0, 1))
{ {
case '-': case '-':
...@@ -131,6 +153,8 @@ class Redis { ...@@ -131,6 +153,8 @@ class Redis {
throw new \Exception("Error making Redis connection: {$error} - {$message}"); throw new \Exception("Error making Redis connection: {$error} - {$message}");
} }
$this->select($this->database);
return $this->connection; return $this->connection;
} }
...@@ -191,6 +215,8 @@ class Redis { ...@@ -191,6 +215,8 @@ class Redis {
list($read, $response, $size) = array(0, '', substr($head, 1)); list($read, $response, $size) = array(0, '', substr($head, 1));
if ($size > 0)
{
do do
{ {
// Calculate and read the appropriate bytes off of the Redis response. // Calculate and read the appropriate bytes off of the Redis response.
...@@ -203,6 +229,7 @@ class Redis { ...@@ -203,6 +229,7 @@ class Redis {
$read += $block; $read += $block;
} while ($read < $size); } while ($read < $size);
}
// The response ends with a trailing CRLF. So, we need to read that off // The response ends with a trailing CRLF. So, we need to read that off
// of the end of the file stream to get it out of the way of the next // of the end of the file stream to get it out of the way of the next
...@@ -225,11 +252,11 @@ class Redis { ...@@ -225,11 +252,11 @@ class Redis {
$response = array(); $response = array();
// Iterate through each bulk response in the multi-bulk and parse it out // Iterate through each bulk response in the multi-bulk and parse it out
// using the "bulk" method since a multi-bulk response is just a list of // using the "parse" method since a multi-bulk response is just a list
// plain old bulk responses. // of plain old Redis database responses.
for ($i = 0; $i < $count; $i++) for ($i = 0; $i < $count; $i++)
{ {
$response[] = $this->bulk(trim(fgets($this->connection, 512))); $response[] = $this->parse(trim(fgets($this->connection, 512)));
} }
return $response; return $response;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment